On Tue, 11 Feb 2020 at 21:12, Matteo Bruni matteo.mystral@gmail.com wrote:
Somewhat. In this same patch I'm moving wined3d_stateblock_capture() to using ARRAY_SIZE(stateblock->changed.?s_consts_f), this makes sure we're not flagging constants >= d3d_info->limits.?s_uniform_count but still < WINED3D_MAX_?S_CONSTS_F. It's certainly not a big deal, let me know how you prefer that I update the patch (options that I can think of: split these changes out to a separate patch, don't change the loop bounds in wined3d_stateblock_capture(), drop these changes entirely).
I'd probably just put it in a separate patch. Although I also think that at least at the time these stateblock functions were being written, there was some hope that we could get rid of the "device" field in the stateblock, and just check these kinds of limits in d3d9 etc.