On Tue, Sep 9, 2008 at 11:10 AM, Rob Shearman robertshearman@gmail.com wrote:
2008/9/9 Dmitry Timoshkov dmitry@codeweavers.com:
"Steven Edwards" winehacker@gmail.com wrote:
[PATCH] Open file in binary mode to work around a windows bug
What bug is that? If that's a Windows bug why Wine needs to be patched?
It's not a bug. When opening a file in text mode on Windows, all LFs will be converted to CRLFs. Typelib files are binary and therefore random parts of the typelib data will seemingly be corrupted when read.
The patch is correct, even if the description isn't.
Sorry I should have said "Allow opening files in binary mode to avoid corruption from text mode on Windows" or some such. I know the line LF/CRLF stuff is not really a bug as there is not a standard that says "All line endings should follow the Unix method" I just view the historic dos/windows usage as a bug.
If Alexandre does not apply it I will resend.