Hi Gabriel,
On 02.03.2020 14:39, Gabriel Ivăncescu wrote:
Each named item should have its own associated script dispatch object. Identifiers are added to this object, but code does look into the global script object as well.
Signed-off-by: Gabriel Ivăncescugabrielopcode@gmail.com
dlls/jscript/compile.c | 2 ++ dlls/jscript/dispex.c | 1 + dlls/jscript/engine.c | 33 ++++++++++++++++-- dlls/jscript/engine.h | 2 ++ dlls/jscript/global.c | 9 ++++- dlls/jscript/jscript.c | 78 ++++++++++++++++++++++++++++++++++++++++-- dlls/jscript/jscript.h | 2 ++ 7 files changed, 121 insertions(+), 6 deletions(-)
Please try to split it some more, it's not really reviewable in current form. I know it may be tricky to get it split without breaking anything, but I think it could be done. One way to do it would be to introduce script_obj inside named item struct, but set it to global script object. Using it would then behave just like current use of global object. You could then replace its usage one by one (which should make it a lot easier to review). Once all users are fixed, you may then change it to be a separated object in most cases.
Thanks,
Jacek