Hi Matteo, Thanks for commenting on my patch
2015-08-27 0:45 GMT+08:00 Matteo Bruni matteo.mystral@gmail.com:
SHCreateDirectoryExW can probably legitimately fail so I don't think an ERR is appropriate here. A WARN might be okay. While at it, please add a space between 'if' and '('.
I think it could be more challenging than I expected to handle the errors. I'll look into it deeper.
Unrelated preexisting issue, those helper functions for SHFileOperationW() like move_files() return a DWORD but the error code is otherwise int. It shouldn't matter in practice but it would be nice to fix that (in a separate patch).
I agree with you. DWORD is unsigned, but SHFileOperationW returns a int value. I'll write a patch to fix it,
PS. Thanks to Sebastian Lackner's comment on my patch: https://bugs.wine-staging.com/show_bug.cgi?id=541#c3