Gijs Vermeulen gijsvrm@gmail.com wrote:
Op wo 21 apr. 2021 om 21:14 schreef Dmitry Timoshkov dmitry@baikal.ru:
Removing dynamic loading of ntdll APIs will unnecessarily break building the tests with older PSDK versions, in particular Windows 7/8 ones. I'm occasionally use Windows 7 to test things, I'd appreciate if building under that platform keeps working.
Isn't this already the case? (i.e. RtlInitUnicodeString in set_env_var() and RtlSetCurrentEnvironment in test_RtlSetCurrentEnvironment())
I haven't built the ntdll tests for some time, so probably something went in and broke things, however fixing a couple APIs is much less trouble than dealing with completely broken test. Is keeping dynamic API loading something that can't be left as it is, without making things worse? Honestly, it doesn't require that much effort.