Re: [PATCH 1/2] d3drm: Change signature of d3drm_texture_create.

[Aaryaman Vasishta]

On Wed, Mar 16, 2016 at 5:29 PM, Henri Verbeet  wrote:
> >  FIXME("iface %p, image %p, texture %p partial stub.\n", iface,
>
> image, texture);
> > - struct d3drm_texture *object;
> > - HRESULT hr;
>
> You mix declarations and code here. The compiler should have warned about
> that.

clang didn't warn me about that. I should still fix it though. Does clang
need -Wall for that warning to come?
> > +IDirect3DRMTexture *IDirect3DRMTexture_from_impl(struct d3drm_texture
>
> *texture)
> > +{
> > - return &texture->IDirect3DRMTexture_iface;
> >
> > +}
> > -
> >
> > +IDirect3DRMTexture2 *IDirect3DRMTexture2_from_impl(struct d3drm_texture
>
> *texture)
> > +{
> > - return &texture->IDirect3DRMTexture2_iface;
> >
> > +}
> > -
> >
> > +IDirect3DRMTexture3 *IDirect3DRMTexture3_from_impl(struct d3drm_texture
>
> *texture)
> > +{
> > - return &texture->IDirect3DRMTexture3_iface;
> >
> > +}
>
> I don't think these are an improvement, I'd prefer them just written out.

That's fine with me too, I kept them there for future use, but that doesn't
seem to be the case. I should add these only if really required (like for
devices).

I'm currently caught up in a college project presentation which ends this
weekend, I'll submit all changes this weekend mostly.

Thanks for the review! Once this is done we can move on to the 2nd patch
(of which i'll be sending another patch which will apply without the
trailing whitespace, though more revision is required there anyways.)

Cheers,
Aaryaman