On Sun, 16 Feb 2014, Dmitry Timoshkov wrote: [...]
- cab_ULONG window_size; /* window size (1Kb through 2Mb) */
- cab_ULONG window_size; /* window size (1 KB through 2 MB) */
[...]
In my years of University the students were told to remember that 1Kb == 1024 bytes, 1Mb == 1024Kb and size prefixes should be written as a capital letter to emphasize its meaning.
'1Kb' is some number of bits, not bytes and is nowhere close to 1024 bytes. So that's one thing that really needed fixing in the old comment.
Now as for the always confusing 1000 vs 1024 ambiguity and kB vs. KB vs. KiB aspect I don't care.
Reference: * https://en.wikipedia.org/wiki/Bit The symbol for bit, as a unit of information, is either simply bit (recommended by the ISO/IEC standard 80000-13 (2008)) or lowercase b (recommended by the IEEE 1541 Standard (2002)).
* https://en.wikipedia.org/wiki/Byte#Unit_symbol The unit symbol for the byte is specified in IEC 80000-13, IEEE 1541 and the Metric Interchange Format as the upper-case character B.
The unit symbol kB is commonly used for kilobyte, but may be confused with the still often-used abbreviation of kb for kilobit. IEEE 1541 specifies the lower case character b as the symbol for bit; however, IEC 80000-13 and Metric-Interchange-Format specify the abbreviation bit (e.g., Mbit for megabit) for the symbol, providing disambiguation from B for byte.
* https://en.wikipedia.org/wiki/Kilobyte All existing recommendations prefer to use the uppercase letter B for byte, because b is used for the bit.
Just as a note, in the GUI we seem to be using 'k' (*), 'kB', 'MB' and 'GB'. If anyone wants to change the first two to 'KB' I'm fine with that. The 'KiB' variants may prove too confusing for non technical users however.
(*) Look for '64k'.