Re: [PATCH 2/3] shell32: Implement FolderItems_Item.

[Nikolay Sivov]

On 21.07.2016 7:45, Alex Henrie wrote:
> static HRESULT WINAPI FolderItemsImpl_Item(FolderItems3 *iface, VARIANT index, FolderItem **ppid)
>  {
> - FIXME("(%p,%s,%p)\n", iface, debugstr_variant(&index), ppid);
> -
>
> FolderItemsImpl *This = impl_from_FolderItems(iface);
> -
>
> VARIANT path;
> -
>
> struct list *node = list_head(&This->items);
> -
>
> int i;
> -
> -
>
> TRACE("(%p,%s,%p)\n", iface, debugstr_variant(&index), ppid);
>
> *ppid = NULL;
> - return E_NOTIMPL;
> -
> - if (!node)
> -
>    return S_FALSE;
> -
> - for (i = 0; i < V_I4(&index); i++)
> - {
> -
>    node = list_next(&This->items, node);
> -
>    if (!node)
> -
>        return S_FALSE;
> - }

If it's only using indexed access, list is not a right data type.