Re: [PATCH v6 1/6] winedbg: Refactor gdb_context::out_{buf*, len} into reply_buffer.

[Rémi Bernon]

On 11/23/21 16:15, Jinoh Kang wrote:
> > > +static inline void reply_buffer_append_str(struct reply_buffer* reply, const char* str)
> > > +{
> > > +    reply_buffer_append(reply, (const void *)str, strlen(str));
> > > +}
> > > -
> >
> > This function is unused in this patch, it should be added in the next one, where it is. You probably don't need the inline by the way, here or elsewhere, and you don't need to cast to const void* either.
>
> I just realised I forgot to take the inline keyword out.  The reason why inline
> is there was simply because the old code was using it; nothing more.  I don't
> think its presence or absence would make a big difference, though.

Yes, it doesn't really matter. It silents the unused function warning 
with GCC though, Clang still emits it.