Re: [PATCH 2/5 v2] riched20/tests: Rewrite tests for ITextServices_TxGetNaturalSize().

[Huw Davies]

On Wed, May 23, 2018 at 04:43:58PM +0800, Jactry Zeng wrote:
> Hi Huw,
>
> Thanks for review.
>
> Huw Davies  于2018年5月23日周三 下午4:34写道：
> > While the original test isn't great, it does at least compare the
> > returned size to font metrics.  You'll need to figure out the
> > algorithm rather than just hardcoding a (very large) range.
>
> That range looks large is because that the Japanese Windows
> testbot has a different font. And That minimum is for the Japanese testbot.
> Can I just skip these tests in Japanese testbot and supplement
> some more tests for comparing the returned size to font metrics?

No, it's good to have the test run with multiple fonts.  You'll
have to figure out how to get the natural size from the font
metrics.

Huw.