Re: Checking for manifest in comctl32 for custom draw

[Gabriel Ivăncescu]

On 2/27/19 3:01 PM, Nikolay Sivov wrote:
> On Wed, Feb 27, 2019 at 3:26 PM Gabriel Ivăncescu 
> <[e-mail] > wrote:
> Trying to implement custom draw for buttons to fix
> https://bugs.winehq.org/show_bug.cgi?id=10531  and I have a question
> about the manifest as mentioned in the bug report.
>
> I notice that the tests already assume that comctl32 has these enabled,
> and they work on Windows, so is it really necessary to check for the
> manifest at all? Obviously, fixing this would only go into
> comctl32/button and not in user32/button because the latter doesn't
> have
> custom draw on Windows.
>
> Do I still have to check for the manifest? And if so, can someone
> please
> point me to the right direction on how to do that? I've no knowledge of
> this at all.
>
>
> No, with current wine you don't have to do anything. Once you've hit 
> comctl32/button code it means
> activation context checks and alternate class registration already happened.
>
> Yes, newer functionality will go to comctl32/button.c only, that 
> separation was exactly for that.
> Regarding bug report, it only mentions general idea.

Ah I see, thanks Nikolay!

(yes bug report mentions general idea, my intent is to implement it 
properly, writing tests for many cases etc)