I noticed on Bugzilla that there was a follow up on this by Fabian Maurer. I posted my findings below his. Here is the link: https://bugs.winehq.org/show_bug.cgi?id=47489
Here is what I wrote:"I've been working on this one while learning Wine code. I wrote an app for this a while ago using some Windows API calls.
What I found was that for a Combobox the CB_SETITEMHEIGHT message was taking precedence over SetWindowPos() in Wine, whereas in Windows the last one called is what takes precedence.
I noticed that CB_SETITEMHEIGHT locks the height in in the function GB_GetTextAreaHeight() in dlls/comctl32/combo.c (and probably in the user32/combo.c as well).
I'm not familiar enough with Wine's code to make a repair right now, but, at the very least, this shows a divergence between Wine and Windows.
I'll study the code more to see if I can fix it." Regards,...John Alway On Wednesday, October 30, 2019, 07:10:59 PM CDT, Thales thaleslv@yahoo.com wrote:
Hello Alistair. I'm working on Bug #47489"The appearance of configurable options in Audacity is broken"
https://bugs.winehq.org/show_bug.cgi?id=47489
Basically the bug is that comboboxes are displayed with the wrong height. I see that I may have written the test in the wrong way. I wrote my test in Visual Studio on Windows. It demonstrates the error by honing in on some api calls. However, I just read the article linked below under the heading "Writing Tests". Is that the way I should go about writing my test? https://www.codeweavers.com/about/blogs/aeikum/2019/1/17/working-on-wine-par...
Thanks for your feedback! ...John Alway
On Tuesday, October 29, 2019, 11:58:58 PM CDT, Alistair Leslie-Hughes leslie_alistair@hotmail.com wrote:
Hi John,
What bug are you referring to?
If the patch isn't too big, sent it the list without a signoff and a comment asking for a review.
And/Or attach it the bug report, however reviews aren't done on bugzilla patches, but the code wouldn't be lost either.
Regards
Alistair.
On 30/10/19 3:39 pm, Thales wrote:
Hello everyone, I was able to figure out the source of a bug for one of the bugs listed in Bugzilla. I wrote a little demo app with Windows API functions to show it. I hesitated to fix the problem in Wine, because the code is complex and therefore wasn't sure what the ramifications would be. How do I go about presenting this to those who deal with bugs? Many thanks for any feedback! Regards,John Alway