Re: [PATCH v5] comctl32: Implement handling of EM_SETCUEBANNER/EM_GETCUEBANNER messages.

[Nikolay Sivov]

On 10/24/2018 10:46 PM, Sergio Gómez Del Real wrote:
> +static BOOL EDIT_EM_GetCueBanner(EDITSTATE *es, WCHAR *buf, DWORD size)
> +{
> - if (!es->cue_banner_text)
> - {
> -
>    if (!(es->style & ES_MULTILINE) && buf && size)
> -
>        *buf = 0;
> -
>    return FALSE;
> - }

I think it's better to move multiline test outside, before testing 
anything else.
> - else
> - {
> -
>    if (buf && size)
> -
>        lstrcpynW(buf, es->cue_banner_text, size);
> -
>    return TRUE;
> - }
>
> +}

You can remove zero size check.
> - case EM_SETCUEBANNER:
> -
>    result = EDIT_EM_SetCueBanner(es, (const WCHAR *)lParam);
> -
>    break;

How did you test wParam flag? It seems to work for me as docs describe.