Re: [PATCH 1/5] win16/int21: make found filename uppercase.

[David Laight]

On Wed, May 30, 2012 at 01:32:28PM +0200, Alexandre Julliard wrote:
> Oleksij Rempel  writes:
> > @@ -3961,6 +3962,8 @@ static int INT21_FindNext( CONTEXT *context )
> >              INT21_FindPath = dta->fullPath = NULL;
> >          }
> >          dta->count = n;
> > -
> >    p = dta->filename;
> > -
> >    for ( ; *p; p++) *p = toupper(*p);
>
> Using toupper is probably not a good idea on OEM codepage strings. Which
> app depends on this?

I'd also guess that 'p' is defined as 'char *'.
The domain of toupper() isn't char, the value must be cast to
'unsigned char' (or the pointer to 'unsigned char *').

David