Aric Stewart aric@codeweavers.com wrote:
LIST_FOR_EACH(family_elem_ptr, &font_list) { family = LIST_ENTRY(family_elem_ptr, Family, entry);
if (!strcmpiW(family->FamilyName, FaceName) ||
(psub && !strcmpiW(family->FamilyName, psub->to.name)))
if ((!psub && !strcmpiW(family->FamilyName, FaceName)) ||
( psub && !strcmpiW(family->FamilyName, psub->to.name))) { LIST_FOR_EACH(face_elem_ptr, &family->faces) { face = LIST_ENTRY(face_elem_ptr, Face, entry);
Changing the order of 2 comparisons in the 'if' block would be clear IMO, and would help avoiding to check psub twice.