I'm pretty sure lots of other wine code uses 2 space indents, I know I started using them after working with wine.
No other comments on the ui changes in winecfg? ;-) I'll submit to wine-patches tonight after going through the code once more.
The x11 tab is global settings only at this point. I think we can remove a couple of options on this tab, UseRandR is the only one I can think of atm. If we do make x11 settings per-app/global, like the apps and libraries tab, it seems like we should somehow combine the tabs. Yet is is nice having distinct tabs. In any case, I don't use per-app x11 settings so unless someone decides to implement this I likely won't be back at it for a while.
Thanks, Chris
From: "Dimitrie O. Paun" dimi@intelliware.ca Date: 2004/02/04 Wed PM 02:14:59 EST To: Chris Morgan chmorgan@charter.net CC: wine-devel@winehq.com Subject: Re: [Winecfg] - redo applications tab, misc changes
On Tue, 3 Feb 2004, Chris Morgan wrote:
Comments, questions, suggestions welcome ;-)
The one complaint I have is that it changes the 4-space indentation to 2-space indentation, which makes the code so much harder to follow. I know, you're doing the work, so you get to chose :), but if it's not too much to ask, can we please stick to 4-space indentation?
-- Dimi.