On Wed, Apr 29, 2020 at 7:59 PM Nikolay Sivov bunglehead@gmail.com wrote:
If it's not documented anywhere, shouldn't we keep original author notice, even if it's a stub?
I will put a notice that its based on a previous patch from Austin English.
There is still a question on how this implementation was developed in freerdp.
I am not trying to implement it using the implementation in FreeRDP, it will remain as a stub. Till we have sufficient tests available. I wrote initial tests which only check the function inputs. As I could not completely test those on testbot, I have sent the initial patches.