On 1 April 2013 16:56, Sam Edwards cfsworks@gmail.com wrote:
In the meantime, should I resend this patchset (with the reset_device() change included) so that it can be reviewed and committed while I'm busy with ddraw (and send the ddraw tests in a separate patch), or is this patchset unacceptable until I include the ddraw tests?
I wouldn't go so far as to say it's unacceptable without the ddraw tests, but I do think it would be preferred to submit them in the same set. For what it's worth, I don't think the ddraw tests have to be particularly complicated, you'd essentially just add a SetCooperativeLevel(..., DDSCL_NORMAL); call and then test that the style flags are unchanged from their initial values.