Re: [PATCH 4/5] wined3d: Reject unsupported pitches in wined3d_surface_update_desc().

[Stefan Dösinger]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Am 2015-02-18 um 14:20 schrieb Matteo Bruni:
> - if (pitch & (texture_resource->format->byte_count - 1))
> - {
> -
>    WARN("Pitch unsupported, not a multiple of the texture format byte width.\n");
> -
>    return WINED3DERR_INVALIDCALL;
> - }

I'd prefer this to be an ERR instead, and the return statement removed.
The idea is that since we don't ever expect this check to be true it
shouldn't result in different behavior and can be compiled out in a
build where debugging is disabled.

The basic idea originated from Henri:
https://www.winehq.org/pipermail/wine-devel/2013-August/100974.html .
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAEBAgAGBQJU5KrDAAoJEN0/YqbEcdMwdj0P/0kphTArNNtcxtIbt5noekiX
wTwi7X6YhxkjryHENqvYKKO8ckBftBoxJHo9o4I82Cc+IRvj9GvrvvuZ5FuiMsJO
6dGmo5JSHnGGNG3rl/oZt31v3P/1LAba3GoFAgRwBfXCULue6gNRyC8+57ahlbLy
xVWc2m249URRP3ML/O9+bXlzA61oQdS+5q54T+jmYv3X8K8AgDHATu114mcpxaAq
hkHIKmW2WCoigCBrNHQTzcxMG3lsavMbnuMxSvQ/01/mwrKvmYYkvvBtR/AVI6W+
I7HLF4KZlz5BLZnS71joW2LLL35/z/3qtmaHi8dq/kCMaajow9dBQmstcUFvwJ4p
UknSxgcCOgKreAZH3yTOH5LNgf8qZvB21wQ5Cn0NGEBW7bZKdUxfRftFN8IQY1Ht
NhGB9cmvo3Ozv0z+i7wMfcXjntT9wL/2H77RqC4Xb9Z/igo+E2LJN0XqQYvwvtj7
wG4Fw5rH7vrO4g/IcfFYvbT7CMUYrPWtFaTfiMn5IOQZ4mx2gacktHcpZJnCUjw5
/uTQo+089YosnM+xY/WvDnjjI13svZt5c3gUMlvha30RjsX7PDfih/vNrr0qR5Y/
C6TLk8ffbmPOX6TTobndfZrWdb2sP3d7x1T1tx9nMAKJG0HFy5wvFoygEDOzFRYU
tG/x7wnrmr3fYfUSEPJY
=LuAf
-----END PGP SIGNATURE-----