Re: [PATCH resend v5 4/5] mountmgr: Add support for volume information queries.

[Erich E. Hoover]

On Thu, Feb 4, 2021 at 11:42 AM Chip Davis  wrote:
> February 4, 2021 10:40 AM, "Erich E. Hoover"  wrote:
> > @@ -1826,6 +1828,117 @@ static void query_property( struct disk_device *device, IRP *irp )
> > [...]
> > +done:
> > - LeaveCriticalSection( &device_section );
> > - IoCompleteRequest( irp, IO_NO_INCREMENT );
> > - return STATUS_SUCCESS;
> >
> > +}
>
> Shouldn't that return what's in io->u.Status? I thought MS recommended doing that for driver dispatch handlers.

I just copied what we were doing in
dlls/mountmgr.sys/device.c:harddisk_ioctl, and it looks like it used
to be that way and AJ changed it in
41eb2fd714c18422381f46e8b4f3608c06bef627.  Do you happen to have a
link to wherever you saw that recommendation?

Best,
Erich