Re: wine/dlls/avifil32: implemented many functions

[Dimitrie O. Paun]

On October 13, 2002 08:19 am, Michael Guennewig wrote:
> | ./controls/menu.c:                      p = strchrW (p + 2, '&');

This is OK for strchrW, 'cause it will expand the 
char to a WCHAR automatically.
> | ./dlls/comctl32/comctl32undoc.c:  return strchrW(lpStart, wMatch);
> | ./dlls/comctl32/comctl32undoc.c:    if( strchrW(lpSet, *(WORD*)lpLoop))

WORD is like a WCHAR, it works.
> | ./dlls/msvcrt/dir.c:  if ((ptr = strchrW(path, (WCHAR)L':')) != (WCHAR)L'\0')

Works as well, but I find it unnecessarily complicated.
> | ./dlls/shlwapi/url.c:               mp = strchrW(wk1, L'/');

I say, don't bother with the L, because it means the compiler will have
to do a lossy 32-bit to 16-bit conversion.

I say the first version is just fine (for ASCII chars!).