Re: wined3d: remove a useless variable

[Nikolay Sivov]

On 11/14/2010 22:41, David Adam wrote:
> 2010/11/14 Nikolay Sivov <[e-mail] 
> >
> On 11/14/2010 22:17, David Adam wrote:
>
>          if(wined3d_settings.rendertargetlock_mode == RTL_DISABLE) {
>     -        static BOOL warned = FALSE;
>     -        if(!warned) {
>     -            ERR("The application tries to lock the render
>     target, but render target locking is disabled\n");
>     -            warned = TRUE;
>     -        }
>     +        ERR("The application tries to lock the render target,
>     but render target locking is disabled\n");
>              return;
>          }
>
> Why is it useless?
>
>
> Maybe I missed something:
>
> Since warned= False we always enter in the if condition. Then 
> warned=TRUE. But we leave the first if condition that is the lifetime 
> of the variable. So the variable is destroyed ans is useless.
>
> Am I wrong?

Well, yes. It's static. It's used to display error output once.
> A+
>
> David