On Mon, 16 Sep 2019 19:29:47 -0500, Zebediah Figura wrote:
Signed-off-by: Zebediah Figura z.figura12@gmail.com
As might be implied by this patch, I also have patches to replace the AVI splitter and the MPEG-1 splitter with avidemux and mpegaudioparse, respectively.
This of course means requiring GStreamer to decode all media files. I'm not particularly inclined to see this as a blocking problem, especially since the required plugins are all in the "good" set, which as far as I'm aware has full multiarch handling in all major distributions.
I'm so exciting to hear this idea. This might be outside the scope of your improvements, but what do you think about decoding MPEG-1 video streams? GStreamer's mpegpsdemux and mpegvideoparse are in the "bad" set and have multi-arch issue in Ubuntu 18.04 LTS[1]. [1] gstreamer1.0-plugins-bad package depends on liblilv-0-0 0.24.2~dfsg0-1 package which doesn't support multi-arch. (Debian bug #904099)
Regarding the patch, it's very long. You might want to split into two parts, e.g. i) introducing init_gst member and make gstdecoder_init_gst, ii) move WAVE parser function to winegstreamer and add wave_parser_init_gst.
Akihiro Sagawa