Kees Beets kbeets68@gmail.com writes:
Fixes https://bugs.winehq.org/show_bug.cgi?id=38231
Removed code introduced in 2006 to correctly reflect Win9x 16-bit winpos behaviour. Newer versions of Windows do not have the 16-bit constraint and this code is now actually causing a bug in Adobe Lightroom on Wine. I've not used iswin9x to ensure compatibility with Win9x as:
- Applications that can run on Win9x should take care of this
- Adding such code will over time make wine more complex
Tested on Ubuntu 16.04, HP Elitebook with AMD A10. 13 failures before change, 10 failures after change. Test code uses iswin9x, so to have 0 failures means changes to the test suite or further introduction of 'if isinw9x' logic.
Signed-off-by: Kees Beets kbeets68@gmail.com
dlls/user32/winpos.c | 16 ---------------- 1 file changed, 16 deletions(-)
It breaks the tests:
../../../tools/runtest -q -P wine -T ../../.. -M user32.dll -p user32_test.exe.so win && touch win.ok win.c:776: Test failed: bad winpos->x -32769 win.c:777: Test failed: bad winpos->y -40000 win.c:795: Test failed: bad winpos->x -32769 win.c:796: Test failed: bad winpos->y -40000 win.c:776: Test failed: bad winpos->x 32768 win.c:777: Test failed: bad winpos->y 40000 win.c:795: Test failed: bad winpos->x 32768 win.c:796: Test failed: bad winpos->y 40000 Makefile:649: recipe for target 'win.ok' failed