Re: [PATCH vkd3d 06/10] vkd3d: Implement d3d12_command_list_SetName().

[Józef Kucia]

On Thu, Jan 31, 2019 at 8:33 AM Zhiyi Zhang  wrote:
> Signed-off-by: Zhiyi Zhang
>
> libs/vkd3d/command.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/libs/vkd3d/command.c b/libs/vkd3d/command.c
> index 47c8854..f05b40c 100644
> --- a/libs/vkd3d/command.c
> +++ b/libs/vkd3d/command.c
> @@ -1694,9 +1694,10 @@ static HRESULT STDMETHODCALLTYPE d3d12_command_list_SetName(ID3D12GraphicsComman
>  {
>      struct d3d12_command_list *list = impl_from_ID3D12GraphicsCommandList(iface);
> - FIXME("iface %p, name %s stub!\n", iface, debugstr_w(name, list->device->wchar_size));
> - TRACE("iface %p, name %s.\n", iface, debugstr_w(name, list->device->wchar_size));
> - return E_NOTIMPL;
> - return vkd3d_set_vk_object_name(list->device, (uint64_t)(uintptr_t)list->vk_command_buffer,
> -
>                                VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, name);;
>
> }

This isn't correct. A d3d12 command list usually uses multiple
VkCommandBuffers through its lifetime. d3d12_command_list_Reset()
allocates a new VkCommandBuffer for the command list.

(Also double semicolons, and formatting looks wrong).