Re: [PATCH 3/4] msvcp110: Add _Pad implementation

[Sebastian Lackner]

On 22.02.2016 19:31, Piotr Caban wrote:
> /* ??4_Pad@std@@QAEAAV01@ABV01@@Z */
> @@ -901,8 +907,12 @@ _Pad* __thiscall _Pad_ctor(_Pad *this)
>  DEFINE_THISCALL_WRAPPER(_Pad_op_assign, 8)
>  _Pad* __thiscall _Pad_op_assign(_Pad *this, const _Pad *copy)
>  {
> - FIXME("(%p %p) stub\n", this, copy);
> - return NULL;
> - TRACE("(%p %p)\n", this, copy);
> -
> - this->cnd = copy->cnd;
> - this->mtx = copy->mtx;
> - this->launched = copy->launched;
> - return this;
>
> }

The assignment of cnd and mtx looks a bit suspicious. Does that
really work as expected (especially when the dtor is called later)?