Re: [PATCH 6/6] d3dx9: Add test for D3DXSHMultiply3 arguments aliasing.

[Matteo Bruni]

2016-04-14 14:10 GMT+02:00 Paul Gofman :

A few nitpicks:
> - const FLOAT expected_aliased[20] =
> - { 454.092499f,2.126404f, 5.570401f, 15.330379f, 22.796087f, 43.604126f,
> -
>  4.273841f, 175.772034f, 237.672729f, 1.09f, 1.1f, 1.11f, 1.12f, 1.13f,
> -
>  1.14f, 1.15f, 1.16f, 1.17f, 1.18f, 1.19f };

You can use just 'float' and the indentation style we use in "modern"
code. You can fixup the previous array declaration too if you want but
it's also fine if you don't.
> - for (i = 0; i < 20; i++)
> -
>    c[i] = a[i];
> - D3DXSHMultiply3(c, c, b);
> - for (i = 0; i < 20; i++)
> -
>    ok(relative_error(c[i], expected_aliased[i]) < admitted_error, "Expected[%d] = %f, received = %f\n", i, expected[i], c[i]);

This line is too long.