Re: oleaut32: Use BOOL type where appropriate

[Nikolay Sivov]

On 2/22/2014 15:22, Frédéric Delanoy wrote:
> dlls/oleaut32/varformat.c | 8 ++++----
>   dlls/oleaut32/vartype.c   | 2 +-
>   2 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/dlls/oleaut32/varformat.c b/dlls/oleaut32/varformat.c
> index e72a170..a6a10cf 100644
> --- a/dlls/oleaut32/varformat.c
> +++ b/dlls/oleaut32/varformat.c
> @@ -2303,9 +2303,9 @@ HRESULT WINAPI VarFormatNumber(LPVARIANT pVarIn, INT nDigits, INT nLeading, INT
>       if (nLeading == -2)
>         GETLOCALENUMBER(LOCALE_ILZERO, LeadingZero);
>       else if (nLeading == -1)
> -
>  numfmt.LeadingZero = 1;
> -
>  numfmt.LeadingZero = TRUE;
> else
> -
>  numfmt.LeadingZero = 0;
> -
>  numfmt.LeadingZero = FALSE;
>
> if (nGrouping == -2)
> {
>
> @@ -2484,9 +2484,9 @@ HRESULT WINAPI VarFormatCurrency(LPVARIANT pVarIn, INT nDigits, INT nLeading,
>       if (nLeading == -2)
>         GETLOCALENUMBER(LOCALE_ILZERO, LeadingZero);
>       else if (nLeading == -1)
> -
>  numfmt.LeadingZero = 1;
> -
>  numfmt.LeadingZero = TRUE;
> else
> -
>  numfmt.LeadingZero = 0;
> -
>  numfmt.LeadingZero = FALSE;

That's not a case when it's appropriate - 'LeadingZero' is UINT, not BOOL.
Somewhat improved variant of above conditions could look like that:

---
      else
        numfmt.LeadingZero = nLeading == -1;
---