On Fri, 28 Sep 2018, Henri Verbeet wrote:
On 27 September 2018 at 10:55, Francois Gouget fgouget@free.fr wrote:
Signed-off-by: Francois Gouget fgouget@free.fr
dlls/wined3d/adapter_gl.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-)
I don't necessarily want to block this going in if you really care about this, but I also think the name-change is completely ridiculous.
You mean Apple's decision to change the name or the patch ;-)
The thing is that "MacOS X" is a misspelled form of "Mac OS X", the former OS name, so my script reports it as a typo[1]. And it is with spelling issues as with warnings or test failures: if you let them accumulate you soon cannot tell what's new from what's not[2].
So I can either change that to one of the official names or disable this specific check for Wine. So even though it's a minor issue I typically prefer to just send a patch once in a while. But I can disable this check if you prefer.
[1] Although the X is part of 'X server' the script is still right: it's my understanding that the OS name is either 'Mac OS X' or 'OS X' or now 'macOS', but cannot be 'MacOS'.
[2] And people also copy / paste the bad spelling or get influenced by it; both cases leading to the spread of the misspelled form.