Re: [PATCH 1/3] msscript: Cache state of IActiveScript in ScriptHost struct.

[Jacek Caban]

Hi Jactry,

On 5/31/19 3:10 PM, Jactry Zeng wrote:
> static HRESULT WINAPI ScriptControl_AddCode(IScriptControl *iface, BSTR code)
> @@ -985,9 +991,13 @@ static HRESULT WINAPI ScriptControl_Eval(IScriptControl *iface, BSTR expression,
>       if (!This->host || This->state != Initialized)
>           return E_FAIL;
> - hr = IActiveScript_SetScriptState(This->host->script, SCRIPTSTATE_STARTED);
> - if (FAILED(hr))
> -
>    return hr;
> - if (This->host->script_state != SCRIPTSTATE_STARTED)
> - {
> -
>    hr = IActiveScript_SetScriptState(This->host->script, SCRIPTSTATE_STARTED);
> -
>    if (FAILED(hr))
> -
>        return hr;
> -
>    This->host->script_state = SCRIPTSTATE_STARTED;
> - }

This could use a helper function.

Thanks,

Jacek