Re: [PATCH 1/1] wininet: Fix crash when connection is null in NETCON_secure_connect

[Jacek Caban]

Hi Wei,

On 05.01.2018 02:03, Wei Xie wrote:
> request->netconn may be released before call NETCON_secure_connect.
>
> 5029             if(!request->contentLength)
> 5030                 http_release_netconn(request, TRUE);
>
> 5121             if (secure_proxy_connect && request->status_code ==
> HTTP_STATUS_OK)
> 5122             {
> 5123                 res = NETCON_secure_connect(request->netconn,
> request->server);
>
> I don't know how write a test patch

The whole secure_proxy_connect could really use a rewrite, but for this
particular problem, I think that the right solution would be to not
release connection in line 5030 if secure_proxy_connect is TRUE.

Thanks,

Jacek