On 8/31/22 18:20, Francois Gouget wrote:
On Wed, 1 Jun 2022, Rémi Bernon wrote: [...]
Imho the message should keep the 'Test failed' / 'Test succeeded' prefixes. For instance I think it would look more consistent with something like:
Test succeeded inside todo block:
This is a non flaky todo test which succeeds.Test succeeded inside flaky block:
The message does not reflect that such a test is both flaky *and* todo. Mabe something like this would be clearer: Test succeeded inside flaky todo block:Test marked todo: Test marked flaky: Test failed: Test succeeded:
That can work.
[...]
I think flaky_if should be enough, and then there could be some shortcut global variables for `!strcmp(winetest_platform, "windows" / "wine")`, so it's not too long to write.
So: flaky_if( is_windows ) flaky_if( is_wine ) and plain flaky()
I worry that we would risk name collisions but winetest_is_windows would defeat the purpose. (plus we already have some short potentially collision-prone names and it worked out so far)
It's tempting to have things line is_win10 but again that's likely either too fine grained or not enough which probably makes it useless (is_win10_2009_or_greater).
Yeah I don't think we need something finer for the most common cases. And I believe we're trying to avoid having tests checking Windows versions in general, using feature checks instead.