Hi Nicolas,
Nicolas Le Cam wrote:
2009/10/30 Jacek Caban jacek@codeweavers.com:
Hi Nicolas,
Nicolas Le Cam wrote:
Hi Jacek,
Thanks for feedback. It should handle pointer in every corners IMHO, the left corner can cause failures in winetest.
I'll try to find a better solution. Do you have any hints ?
The test in line 472 is invalid. It looks like all we can do is check if get_x returned something. I'd suggest to set l to 0xdeadbeef before get_x call and test that the value has changed (ok(x != 0xdeadbeef, ...)). That's all we can do. The same applies to get_client[XY] and get_offset[XY] tests.
Thanks,git br Jacek
Hi Jacek,
I did what you've suggested (patch's attached for reference) but I don't think it's the right solution. Test passes on Wine and Windows with such a patch, but we're now ignoring the fact that values are completely different on Wine (only -1 and 0) and Windows (cursor's position relative to something).
I'm trying to find a way to compare values against results from GetCursorPos and friends. What do you think about that, could that be a solution ?
I think your patch might go to Wine. If you can find a solution with more strict tests, that would be even better, but I'm afraid that GetCursorPos might be problematic. We won't know until we try.
Thanks, Jacek