Re: [PATCH 3/6] user32: Split client and kernel parts of unpack_message.

[Jacek Caban]

On 3/24/22 22:09, Alexandre Julliard wrote:
> Jacek Caban  writes:
> > Signed-off-by: Jacek Caban
> >
> > dlls/user32/message.c | 133 +++++++++--------------
> >   dlls/user32/winproc.c | 247 +++++++++++++++++++++++++++++++++++++++++-
> >   dlls/win32u/message.c |   2 +
> >   include/ntuser.h      |   1 +
> >   4 files changed, 297 insertions(+), 86 deletions(-)
>
> This is breaking tests:
>
> tools/runtest -q -P wine -T . -M shell32.dll -p dlls/shell32/tests/shell32_test.exe appbar && touch dlls/shell32/tests/appbar.ok
> appbar.c:226: Test failed: SHAppBarMessage returned 0
> appbar.c:77: Test failed: SHAppBarMessage returned 0
> appbar.c:99: Test failed: SHAppBarMessage returned 0
> appbar.c:249: Test failed: SHAppBarMessage returned 0
> appbar.c:77: Test failed: SHAppBarMessage returned 0
> appbar.c:99: Test failed: SHAppBarMessage returned 0
> appbar.c:261: Test failed: rectangles intersect (0,2145)-(3840,2160) / (0,2150)-(3840,2160)
> appbar.c:77: Test failed: SHAppBarMessage returned 0
> appbar.c:99: Test failed: SHAppBarMessage returned 0
> appbar.c:267: Test failed: rectangles intersect (0,2140)-(3840,2160) / (0,2150)-(3840,2160)
> appbar.c:278: Test failed: SHAppBarMessage returned 0
> appbar.c:77: Test failed: SHAppBarMessage returned 0
> appbar.c:99: Test failed: SHAppBarMessage returned 0
> appbar.c:289: Test failed: rectangles intersect (0,2140)-(3840,2160) / (0,2150)-(3840,2160)
> appbar.c:290: Test failed: rectangles intersect (0,2140)-(3840,2160) / (0,2150)-(3840,2160)
> appbar.c:291: Test failed: rectangles intersect (0,2150)-(3840,2160) / (0,2150)-(3840,2160)
> appbar.c:77: Test failed: SHAppBarMessage returned 0
> appbar.c:99: Test failed: SHAppBarMessage returned 0
> appbar.c:299: Test failed: rectangles intersect (0,2140)-(3840,2160) / (0,2150)-(3840,2160)
> appbar.c:300: Test failed: rectangles intersect (0,2140)-(3840,2160) / (3825,0)-(3840,2160)
> appbar.c:301: Test failed: rectangles intersect (0,2150)-(3840,2160) / (3825,0)-(3840,2160)
> appbar.c:77: Test failed: SHAppBarMessage returned 0
> appbar.c:99: Test failed: SHAppBarMessage returned 0
> appbar.c:310: Test failed: rectangles intersect (0,2140)-(3840,2160) / (3825,0)-(3840,2160)
> appbar.c:311: Test failed: rectangles intersect (0,0)-(3840,15) / (3825,0)-(3840,2160)
> appbar.c:77: Test failed: SHAppBarMessage returned 0
> appbar.c:99: Test failed: SHAppBarMessage returned 0
> appbar.c:319: Test failed: rectangles intersect (0,2140)-(3840,2160) / (0,2150)-(3840,2160)
> appbar.c:320: Test failed: rectangles intersect (0,2140)-(3840,2160) / (3825,0)-(3840,2160)
> appbar.c:321: Test failed: rectangles intersect (0,2150)-(3840,2160) / (3825,0)-(3840,2160)
> appbar.c:326: Test failed: Expected windows[0] to be lower than windows[1]
> appbar.c:332: Test failed: SHAppBarMessage returned 0
> appbar.c:339: Test failed: Some broken Vista boxes don't move the higher appbar down
> appbar.c:345: Test failed: rectangles intersect (0,2150)-(3840,2160) / (3825,0)-(3840,2160)
> appbar.c:351: Test failed: SHAppBarMessage returned 0
> appbar.c:358: Test failed: SHAppBarMessage returned 0
> make: *** [Makefile:112960: dlls/shell32/tests/appbar.ok] Error 36

I can see the problem, sorry about that. I will send a better version 
next week, it doesn't seem appropriate for release day anyway.

Thanks,

Jacek