Date: Mon, 4 Aug 2008 05:20:43 -0700 From: "Dan Kegel" dank@kegel.com
- port some existing accept() conformance tests from ws2_32/tests/sock.c
to use AcceptEx(), add a bit to check the special new features, and make sure they pass on Windows.
On Sun, Aug 10, 2008 at 4:16 PM, Kai Blin kai.blin@gmail.com wrote:
The indentation common in socket.c is either a two-space indent or a four-space indent. Please don't add new code with an eight-space indent.
Also, the common convention for ifs is if (cond) { and not if(cond){
Thanks guys. I only work on this stuff every so often so I apologize for the slow replies. I think I've made the changes kai suggested and I have been working on the Tests that Dan wants.... but for the life of me I can't get some parts of it to work.... Theres just too much code (and repeated code) to sift through. The conformance tests break the AcceptEx code as it is written, (as far as I know) and thus I know the code isn't correct (and i Don't have any windows machines to test the code on)... I will resubmit the patches again in a couple of days if I can figure out what is wrong.
If anyone can tell me how to check to see if there are connections pending on a sockets listen backlog (in the wineserver) and how to post that information into the wineserver main poll loop, im all ears. The wineserver isn't correctly posting these events. ~Scott