On Mon, 15 Apr 2019 at 19:51, Józef Kucia joseph.kucia@gmail.com wrote:
On Mon, Apr 15, 2019 at 4:55 PM Henri Verbeet hverbeet@gmail.com wrote:
Do we really need shader_parse_descriptor_ranges() to be able to handle 1.1 signatures if we also have shader_parse_descriptor_ranges1()? Or alternatively, do we really need shader_parse_descriptor_ranges1()? Likewise for shader_parse_root_descriptor() and shader_parse_root_parameters().
It's implemented that way for ID3D12RootSignatureDeserializer/vkd3d_create_root_signature_deserializer(). This implementation allows parsing root signature 1.1 directly to the old D3D12_ROOT_SIGNATURE_DESC for ID3D12RootSignatureDeserializer (without conversion). We could potentially re-implement vkd3d_create_root_signature_deserializer() and convert root signature 1.1 to 1.0 after it is parsed. The conversion is implemented later in this patch series.
Yeah, that probably makes sense.