Re: [PATCH] ping: Distinguish between timeouts and other failures

[Alex Henrie]

Missatge de Alex Henrie  del dia dj., 8 de març
2018 a les 8:52:
> Missatge de Ruslan Kabatsayev  del dia dj., 8 de
> març 2018 a les 3:16:
> > Wouldn't it be better to use FormatMessage to print exact error
> > instead of "General failure"?
> I can do that, but it will be quite a bit more work because I'll have to
> add all the errors that IcmpSendEcho can set to dlls/kernel32/winerror.mc.
> That's probably the right solution though.

I just checked and the strings created by FormatMessage are incorrect for
these error codes, probably because the codes were reused for WSA errors.
So, my original patch is basically correct: Any specific error messages
would have to come from ping.exe itself.

-Alex