On 06.02.2017 9:55, Dmitry Timoshkov wrote:
Nikolay Sivov bunglehead@gmail.com wrote:
/* FIXME: check other BS_* handlers */if (btn_type == BS_GROUPBOX)InflateRect(&rc, -7, 1); /* GB_Paint does this */How about doing what FIXME suggests?
Sure, at some point. Original report is for group box, fix is limited to it.
Yes, my original patch is only for BS_GROUPBOX buttons, but that doesn't mean that other button style handlers don't have similar bugs. There are not that much of button styles to carfully review and fix if required,
It doesn't, it also doesn't mean they do. What's important is that it doesn't break other style.
and if for some reason you've decided to resubmit the staged patches you should be prepared to spend time to improve the original patches, in this particular case take care of the FIXME.
I worked on this bug during code freeze and have a fix attached there, before your set was linked. So I consider mine as original, and yours as improved ones touching the same issue, whether it was based on mine, or developed separately. That "some reason" you mentioned is that I already spent time on it while working on the report.