Re: [PATCH] ole32: Return error from IStream Clone.

[Huw Davies]

On Tue, Jan 30, 2018 at 10:40:29PM +0000, Daniel Lehman wrote:
>
> From fe5040c66792c63ff28c97265a90dd65525b7340 Mon Sep 17 00:00:00 2001
> From: Daniel Lehman 
> Date: Fri, 19 Jan 2018 10:39:17 -0800
> Subject: [PATCH] ole32: Return error from IStream Clone.
> Signed-off-by: Daniel Lehman
>
> dlls/ole32/stg_stream.c | 7 +------
>  1 file changed, 1 insertion(+), 6 deletions(-)
>
> diff --git a/dlls/ole32/stg_stream.c b/dlls/ole32/stg_stream.c
> index a3abf46..23b5b2c 100644
> --- a/dlls/ole32/stg_stream.c
> +++ b/dlls/ole32/stg_stream.c
> @@ -604,7 +604,6 @@ static HRESULT WINAPI StgStreamImpl_Clone(
>    			   IStream**    ppstm) /* [out] */
>  {
>    StgStreamImpl* This = impl_from_IStream(iface);
> - HRESULT hres;
> StgStreamImpl* new_stream;
> LARGE_INTEGER seek_pos;
>
> @@ -630,11 +629,7 @@ static HRESULT WINAPI StgStreamImpl_Clone(
>
> seek_pos.QuadPart = This->currentPosition.QuadPart;
> - hres = IStream_Seek(*ppstm, seek_pos, STREAM_SEEK_SET, NULL);
> -
> - assert (SUCCEEDED(hres));
> -
> - return S_OK;
> - return IStream_Seek(*ppstm, seek_pos, STREAM_SEEK_SET, NULL);
>
> }

While you're at it, you could remove the #include <assert.h> line.

Huw.