Re: [PATCH 1/6]: msvcp110: Add tr2_sys__Copy_file implementation and test.

[YongHaoHu]

Hi, Piotr.

On 15/6/29 下午5:29, Piotr Caban wrote:
> On 06/27/15 19:49, YongHaoHu wrote:
> > -
> >    ret = p_tr2_sys__Copy_file(tests[i].source, tests[i].dest, 
> >
> > tests[i].fail_if_exists);
> > -
> >    ok(ret == GetLastError(), "test_tr2_sys__Copy_file(): test 
> >
> > %d expect: %d, got %d\n", i+1, GetLastError(), ret);
> > -
> >    ok(errno == 0xdeadbeef, "test_tr2_sys__Copy_file(): test %d 
> >
> > errno expect 0xdeadbeef, got %d\n", i+1, errno);
>
> Please check the return value of the function explicitly. Currently 
> your implementation returns error while it should succeed and it's not 
> visible in the tests.

Because the last error handling is not correct in CopyFile[1], I check 
GetLastError() instead of values. Do you have any good idea?

[1]: https://bugs.winehq.org/show_bug.cgi?id=38772