Re: RFC testbot: Remove the VM status block from the main page.

[Zebediah Figura (she/her)]

On 1/25/21 8:38 AM, Francois Gouget wrote:
> It is buried far far away at the end of the page so I doubt many 
> people actually scroll down to check it out.
>
> As far as showing what the TestBot is doing, the Activity page does that 
> way better. It does require having a TestBot account and being logged in 
> but that hard seems like an issue.
>
> http://winetestbot.dolphin/Activity.pl
>
> The one information one cannot get from elsewhere without an 
> administrator account is the role of each VM (base, winetest, extra, 
> etc.). I'm not sure that's much of an issue.
>
> But maybe I'm wrong and there are some people who would really depend on 
> it. If so let me know which part of it makes it a must have.

For what it's worth, I do look at this sometimes, usually to check the
"current status" field (e.g. to see if a VM is stuck, or just taking a
long time reverting, or as a quick way to gauge what VMs are done
running the daily tests). I guess that's also available via the Activity
tab, but it's another link to click and needs some horizontal scrolling.
I wouldn't care strongly if the status block goes away, though.
> diff --git a/testbot/web/index.pl b/testbot/web/index.pl
> index 39fea3e7a..f4b675172 100644
> --- a/testbot/web/index.pl
> +++ b/testbot/web/index.pl
> @@ -182,48 +182,6 @@ sub GenerateDataCell($$$$)
>  }
>
> -package VMStatusBlock;
> -
>
> -use ObjectModel::CGI::CollectionBlock;
> -our @ISA = qw(ObjectModel::CGI::CollectionBlock);
> -
> -
>
> -sub SortKeys($$)
> -{
> - my ($self, $Keys) = @_;
> -
> - return $self->{Collection}->SortKeysBySortOrder($Keys);
>
> -}
> -
>
> -sub GetItemActions($)
> -{
> - #my ($self) = @_;
> - return [];
>
> -}
> -
>
> -sub GetActions($)
> -{
> - #my ($self) = @_;
> - return [];
>
> -}
> -
>
> -sub DisplayProperty($$)
> -{
> - my ($self, $PropertyDescriptor) = @_;
> -
> - my $PropertyName = $PropertyDescriptor->GetName();
> - return $PropertyName eq "Name" || $PropertyName eq "Type" ||
> -
>     $PropertyName eq "Role" || $PropertyName eq "Status" ||
> -
>     $PropertyName eq "Description";
>
> -}
> -
>
> -sub GetDetailsPage($)
> -{
> - #my ($self) = @_;
> - return undef;
>
> -}
> -
> -
>
> package StatusPage;
>
> use ObjectModel::CGI::Page;
> @@ -268,7 +226,6 @@ sub GenerateBody($)
>    print "<h1>${ProjectName} Test Bot status</h1>\n";
>    print "<div class='Content'>\n";
> - print "<h2>General</h2>\n";
> print "<div class='GeneralStatus'>\n";
> print "<div class='GeneralStatusItem'>";
> if (PingEngine())
>
> @@ -313,18 +270,12 @@ sub GenerateBody($)
>        print "</div>\n";
>      }
>    }
> - print "</div>\n";
> - print "</div><br>\n";
> -
>
> print "<h2><a name='jobs'></a>Jobs</h2>\n";
> my $Jobs = CreateJobs();
> my $JobsCollectionBlock = new JobStatusBlock($Jobs, $self);
> $JobsCollectionBlock->GenerateList();
> -
>
> print "<h2><a name='vms'></a>VMs</h2>\n";
> -
>
> my $VMsCollectionBlock = new VMStatusBlock(CreateVMs(), $self);
> -
>
> $VMsCollectionBlock->GenerateList();
> -
>
> print "</div>\n";
> -
>
> print "<p class='GeneralFooterText'>Generated in ", Elapsed($self->{start}), " s</p>\n";
>
> }