Kai Wasserbäch wrote:
as bug #19762 is open for some time now, fully bisected, the solution applied for several versions in my Debian packages ([0]) without reports about breakage, I hearby propose the reversion of commit 67631163.
http://bugs.winehq.org/show_bug.cgi?id=19762#c21
That commit is another example of a commit that introduced a regression while fixing another regression in another app. This does not prove that commit wrong, however, the burden is now on you (us) to prove it in order to change git.
It's not an impossible task. Even code that seemed to be backed by tests in Wine was changed when the tests were proven wrong/incomplete.
For a start, it may be worth testing that other app and see if it still needs that commit in current Wine. Does anybody know the bug number of that other app's original issue? Finally, are there any tests that support either behavior?
Regards, Jörg Höhle