On 2/1/21 10:49 AM, Alexandre Julliard wrote:
Rémi Bernon rbernon@codeweavers.com writes:
Signed-off-by: Rémi Bernon rbernon@codeweavers.com
dlls/windowscodecs/unix_lib.c | 2 ++ dlls/windowscodecs/wincodecs_private.h | 1 + 2 files changed, 3 insertions(+)
diff --git a/dlls/windowscodecs/unix_lib.c b/dlls/windowscodecs/unix_lib.c index 268a1cd9d16..9255b3ed243 100644 --- a/dlls/windowscodecs/unix_lib.c +++ b/dlls/windowscodecs/unix_lib.c @@ -67,6 +67,7 @@ HRESULT CDECL stream_write(IStream *stream, const void *buffer, ULONG write, ULO return win32_funcs->stream_write(stream, buffer, write, bytes_written); }
+#ifndef WINCODECS_CUSTOM_UNIXLIB HRESULT CDECL decoder_create(const CLSID *decoder_clsid, struct decoder_info *info, struct decoder **result) { if (IsEqualGUID(decoder_clsid, &CLSID_WICPngDecoder)) @@ -97,6 +98,7 @@ HRESULT CDECL encoder_create(const CLSID *encoder_clsid, struct encoder_info *in
return E_NOTIMPL;} +#endif /* WINCODECS_CUSTOM_UNIXLIB */
That doesn't seem like an improvement. I don't see what you gain by sharing this file across dlls.
Well, it was initially duplicated and I changed it on request. I guess it factors the windowscodecs unixlib interface a bit more, helping the module maintenance? I personally don't have much preference here.