On 18/02/2021 11:34, RĂ©mi Bernon wrote:
Ah yes, I just blindly copied everything from ntdll source and never thought about it again.
There's probably not going to be much maintenance to this code, but is it alright then to completely rewrite it to make it more consistent with widl source, or should we still keep it close to the original code to make greps more likely to match both?
I don't see much point in keeping it close to ntdll code in this case, it's already an adopted version of another code. I'd say that it's fine to do some style changes, I wouldn't count them as a complete rewrite.
Jacek