Re: [PATCH 1/7] d3drm: Use CreateObject in IDirect3DRM*::LoadTexture.

[Stefan Dösinger]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Am 2016-05-13 um 22:21 schrieb Aaryaman Vasishta:
> - if (FAILED(hr = d3drm_texture_create(&object)))
> - if (FAILED(hr = IDirect3DRM_CreateObject(iface, &CLSID_CDirect3DRMTexture, NULL, &IID_IDirect3DRMTexture, (void **)texture)))

This line is fairly long and could profit from a line break IMHO.
> - if (FAILED(hr = d3drm_texture_create(&object)))
> - if (FAILED(hr = IDirect3DRM2_CreateObject(iface, &CLSID_CDirect3DRMTexture, NULL, &IID_IDirect3DRMTexture2, (void **)texture)))

I think here you could already put the 2 -> 3 thunk from patch 7. It's a minor issue though.

Overall I'd say wait if Henri has any other comments before resending.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAEBCAAGBQJXOh4hAAoJEN0/YqbEcdMwjeMP+wRn3MLnrgMlB85ZfafutK3g
wml22BVCwzHvHjbPKFhqbrPUIjS4z/PcZ133djjS6dysL2sBfMK4zxKKqVDRp+0V
RRphWDVQehg6dpfaSBEWcEqLvy5eUXbQlGQ9eWGT40++OVZQ/C5rmIDmPt1/pX/H
f2vnjCIKhGaiDS7M29fnakQckr3sjGuQAJXJuAJqyUHyPo4Edu340UJQweLCOIXX
kDXTAJM0ep17xln5FD8RDjukRc1SRg3P+/PzM1PsED0St/talBFdN16DnfNwzOWO
XbE+wlTQnMxeu2ycY5gyTdFxWUq/lqCYL6Z0KYTwBUHIqryz0K2XPnb1fGZUTuKk
B+XsxtOJYkcvJEoStUuEQSwsTEGipuOStj+fSFEoYnOHBqZWl6midQGWrU6Xyd39
TlOFMew6IldjQBgbfEbu9dSGr3xPi4jD5dPfThdTZFTMOmD++K2APKGmhVmc5bon
QOJ+M6uJJQvnyCqnik63uNQcX5UlBf5Guq1op2K6Zbm3V1neipVBQj8+8mUr7weV
HQDccTIyzErBJuEdSDoCuw4womh+UGcFbusWpRjP5lRaa57X9poZO58Ofw61f/HZ
Tqm9bbnuVjwk4hLa8z5wVbd2bQAytkK0ISFP9bnmGIVk8SZIwuU471pqunF6UMsF
Yl/jFc8sJKIeRAe+bGq2
=LMsi
-----END PGP SIGNATURE-----