"Santosh Siddheshwar" santosh.s@sonata-software.com wrote:
This test fails with WINE even after I create the DIALOGINFO structure the first time it enters DefDlgProc. Not sure why this test should work on Windows.
Since I wrote it under Windows it apparently works there.
Basically at the stage where you are setting DM_SETDEFID there are no child windows on the dialog.
Yes, I was also confused when I saw this for the first time.
Then what does DM_SETDEFID and DM_GETDEFID do when there are no child controls on the dialog?
Looks like it should store id in the dialog structure, and only then try to change the look of a control.
My guess is implementation of DEFDLG_SetDefButton may need to change.
Yes, but that's another bug, not related to your patch. Although it would be great if you could fix that as well, don't bother if you have no time, I'll fix it later, this should be a very simple patch.