On 4/2/22 04:25, Mohamad Al-Jaf wrote:
On Fri, Apr 1, 2022 at 4:16 AM Rémi Bernon rbernon@codeweavers.com wrote:
Hi Mohamad, looks alright but do you know a game which is calling it?
Hi Rémi,
Thanks for the feedback.
I haven't come across a game that calls it but seeing as how it doesn't add any significant upkeep I thought I'd implement it regardless. I'm sure there's at least 1 game out there that calls it but has yet to be discovered or reported. -- Kind regards, Mohamad
Yeah I would rather wait to see if we find one. To the contrary to the physical descriptors, which are at least (very badly) documented in the HID specification, and for which I have a bit of hope we may be able to implement them if needed, I couldn't find any information about the MS genre descriptors and they seem to be completely Microsoft specific.
They both seem optional anyway, so returning a not implemented status should be fine, but I think keeping the crash for now may help finding the game which would need it and maybe check what it wants to do with it.
Cheers,