On Mon, Oct 09, 2006 at 03:45:16PM -0700, Dan Kegel wrote:
Dan H., could you have a quick look at Michal's patch?
Well, the patch I sent in didn't crash on my machine, but crashed on Alexandre's (and maybe others' who didn't try to run it). It's pretty hard to fix something that works when you run it, so I never did track down the problem. Probably Rob, I know he's busy, is more qualified to comment on differences between this and what I sent in. The patch should probably add the test to the Makefile. (BTW, I don't think the Makefile patch I sent in will work anymore since Alexandre made various changes to the rules files.)
One thing I'd note is that the test ran flawlessly on Windows when I tried it, so I have no reason to believe there's anything wrong with the test itself. The bugs are either in Wine or WIDL. I don't remember if I ran the test on Windows with a WIDL- or MIDL- generated typelib, but if it runs fine on Windows with a WIDL-generated typelib, I'd look for bugs in Wine. Otherwise, I'd look for bugs in WIDL. I think the test is OK.