Re: kernel32/tests: check return value of alarmThread in test_NamedPipe_2() (try 2)

[Austin English]

On Sat, May 22, 2010 at 9:44 AM, Andrew Nguyen  wrote:
> On Sat, May 22, 2010 at 5:02 AM, Austin English  wrote:
> > Changes from try 1:
> > Fix another typo.
> > Set LastError before checking it
> > Print LastError as a decimal
> > Don't check for INVALID_HANDLE_VALUE as a return value of
> > CreateThread, instead make sure serverThread is not NULL.
> >
> > --
> > -Austin
>
> You're calling SetLastError(0xdeadbeef) at the wrong time in the pipe
> server subtests. If CreateThread fails, you will unconditionally print
> the decimal representation of 0xdeadbeef in the failure messages.
> SetLastError has to be called before CreateThread to ensure that the
> failure messages print a last error that the preceding CreateThread
> call sets.

No more coding at 4:00 AM. Resending, thanks.