Re: [PATCH v7 4/6] wmp: Add seeking and duration

[Alistair Leslie-Hughes]

Hi Anton,

This is more of general thing with this patch set.

I would like to see more errors tested.

On 29/03/18 02:31, Anton Romanov wrote:
> Signed-off-by: Anton Romanov
>  SetEvent(This->stop_event);
>  WaitForSingleObject(This->event_thread, INFINITE);
>
> @@ -1492,15 +1518,33 @@ static HRESULT WINAPI WMPControls_fastReverse(IWMPControls *iface)
>  static HRESULT WINAPI WMPControls_get_currentPosition(IWMPControls *iface, DOUBLE *pdCurrentPosition)

What happens when an NULL value is passed in?
> static HRESULT WINAPI WMPControls_put_currentPosition(IWMPControls *iface, DOUBLE dCurrentPosition)
>  {

What happens when an negative value is passed in?

Regards
Alistair.